Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

slds-text-body--small helper class overrides theme text color #123

Closed
FabienTaillon opened this issue Nov 26, 2015 · 3 comments
Closed

slds-text-body--small helper class overrides theme text color #123

FabienTaillon opened this issue Nov 26, 2015 · 3 comments
Assignees

Comments

@FabienTaillon
Copy link

I've created a box with the slds-theme--error theme, and wanted to display smaller text in it. I used the slds-text-body--small helper class, however this class overrides the theme color by setting text color to #54698d:

<div class="slds-box slds-theme--error">
    <p class="slds-text-body--small">Trailhead is awesome.</p>
</div>
@jina
Copy link
Contributor

jina commented Nov 26, 2015

This utility wasn't designed to be used in the themes, but I can see that there'd be a need for this. I'll take a look at how we want to adjust this. Thanks for the heads up!

In the meantime, if you need a quick fix, here is an override you can drop in your styles:

.slds-theme--error .slds-text-body--small {
  color: inherit;
}

@FabienTaillon
Copy link
Author

I wasn't sure it could be used like this, but as the "APPLIED TO" section was empty, I thought it could be used wherever we wanted.
Thanks for the tip ! :)

@stefsullrew
Copy link
Contributor

Hi @FabienTaillon - I've added this fix to the themes in our utilities. It will be in your build on the next release. Cheers!

@stefsullrew stefsullrew assigned stefsullrew and unassigned jina Dec 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants