Merge pull request #150 from salesforce-ux/feature/lint-zerounit

Throw warnings when units are used on 0 values
salesforce-ux · Dec 1, 2015 · 13824b5 · 13824b5
2 parents 33bc385 + bb80dd5
commit 13824b5
Show file tree

Hide file tree

Showing 5 changed files with 17 additions and 17 deletions.
diff --git a/.scss-lint.yml b/.scss-lint.yml
@@ -76,4 +76,4 @@ linters:
   VendorPrefix:
     enabled: false
   ZeroUnit:
-    enabled: false
+    enabled: true
diff --git a/site/assets/styles/_iframe.common.scss b/site/assets/styles/_iframe.common.scss
@@ -92,7 +92,7 @@ body {
 
     > div {
       position: relative;
-      top: 0px;
+      top: 0;
       background-color: #ccc;
     }
   }

diff --git a/ui/components/docked-composer/flavors/base/index.scss b/ui/components/docked-composer/flavors/base/index.scss
@@ -112,9 +112,9 @@
 
 @include keyframes(pulse) {
   0%, 100% {
-    filter: drop-shadow(0px 0px 4px rgba($color-background-notification-badge, 0));
+    filter: drop-shadow(0 0 4px rgba($color-background-notification-badge, 0));
   }
   50% {
-    filter: drop-shadow(0px 0px 4px rgba(darken($color-background-notification-badge, 10%),1));
+    filter: drop-shadow(0 0 4px rgba(darken($color-background-notification-badge, 10%),1));
   }
 }
diff --git a/ui/components/menus/flavors/dropdown/index.scss b/ui/components/menus/flavors/dropdown/index.scss
@@ -105,7 +105,7 @@
 
       &:after {
         background: $color-background-alt;
-        box-shadow: -1px -1px 0 0px rgba(0, 0, 0, .16);
+        box-shadow: -1px -1px 0 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
 

diff --git a/ui/dependencies/popover.scss b/ui/dependencies/popover.scss
@@ -51,7 +51,7 @@
       @include nubbin(top, $color: $color);
 
       &:after {
-        box-shadow: -1px -1px 0 0px rgba(0, 0, 0, .16);
+        box-shadow: -1px -1px 0 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
@@ -64,7 +64,7 @@
       @include nubbin(top, $color: $color);
 
       &:after {
-        box-shadow: -1px -1px 0 0px rgba(0, 0, 0, .16);
+        box-shadow: -1px -1px 0 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
@@ -83,7 +83,7 @@
       @include nubbin(top, $color: $color);
 
       &:after {
-        box-shadow: -1px -1px 0 0px rgba(0, 0, 0, .16);
+        box-shadow: -1px -1px 0 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
@@ -104,7 +104,7 @@
       @include nubbin(bottom, $color: $color);
 
       &:after {
-        box-shadow: 2px 2px 4px 0px rgba(0, 0, 0, .16);
+        box-shadow: 2px 2px 4px 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
@@ -117,7 +117,7 @@
       @include nubbin(bottom, $color: $color);
 
       &:after {
-        box-shadow: 2px 2px 4px 0px rgba(0, 0, 0, .16);
+        box-shadow: 2px 2px 4px 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
@@ -137,7 +137,7 @@
       @include nubbin(bottom, $color: $color);
 
       &:after {
-        box-shadow: 2px 2px 4px 0px rgba(0, 0, 0, .16);
+        box-shadow: 2px 2px 4px 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
@@ -159,7 +159,7 @@
       @include nubbin(left, $color: $color);
 
       &:after {
-        box-shadow: -1px 1px 2px 0px rgba(0, 0, 0, .16);
+        box-shadow: -1px 1px 2px 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
@@ -172,7 +172,7 @@
       @include nubbin(left, $color: $color);
 
       &:after {
-        box-shadow: -1px 1px 2px 0px rgba(0, 0, 0, .16);
+        box-shadow: -1px 1px 2px 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
@@ -194,7 +194,7 @@
       }
 
       &:after {
-        box-shadow: -1px 2px 3px 0px rgba(0, 0, 0, .16);
+        box-shadow: -1px 2px 3px 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
@@ -213,7 +213,7 @@
       @include nubbin(right, $color: $color);
 
       &:after {
-        box-shadow: 1px -1px 2px 0px rgba(0, 0, 0, .16);
+        box-shadow: 1px -1px 2px 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
@@ -226,7 +226,7 @@
       @include nubbin(right, $color: $color);
 
       &:after {
-        box-shadow: 1px -1px 2px 0px rgba(0, 0, 0, .16);
+        box-shadow: 1px -1px 2px 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
@@ -248,7 +248,7 @@
       }
 
       &:after {
-        box-shadow: 2px -1px 3px 0px rgba(0, 0, 0, .16);
+        box-shadow: 2px -1px 3px 0 rgba(0, 0, 0, .16);
         z-index: -1;
       }
     }
-Original file line number
+Diff line change
@@ Expand Up / @@ -92,7 +92,7 @@ body { @@
         > div {
           position: relative;
-          top: 0px;
+          top: 0;
           background-color: #ccc;
         }
       }
@@ Expand Down @@