Update e2e for new homepage (#5284)

* update e2e for new homepage * enable new home page --------- Co-authored-by: Paweł Chyła <[email protected]>
saleor · Nov 29, 2024 · e947997 · e947997
1 parent 6990b1e
commit e947997
Show file tree

Hide file tree

Showing 6 changed files with 35 additions and 31 deletions.
diff --git a/.changeset/long-colts-shout.md b/.changeset/long-colts-shout.md
@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+E2E tests are now updated for new home page meaing that they don't fail when new home page is enabled.
diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -107,7 +107,7 @@
     "@graphql-codegen/typescript-apollo-client-helpers": "^2.1.10",
     "@graphql-codegen/typescript-operations": "^2.2.4",
     "@graphql-codegen/typescript-react-apollo": "^3.2.5",
-    "@playwright/test": "^1.40.0",
+    "@playwright/test": "^1.47.0",
     "@saleor/app-sdk": "0.47.2",
     "@sentry/cli": "^2.33.0",
     "@swc/jest": "^0.2.26",

diff --git a/playwright/pages/homePage.ts b/playwright/pages/homePage.ts
@@ -12,7 +12,6 @@ export class HomePage {
     readonly sales = page.getByTestId("sales-analytics"),
     readonly orders = page.getByTestId("orders-analytics"),
     readonly activity = page.getByTestId("activity-card"),
-    readonly topProducts = page.getByTestId("top-products"),
     readonly ordersReadyToFulfill = page.getByTestId("orders-to-fulfill"),
     readonly paymentsWaitingForCapture = page.getByTestId("orders-to-capture"),
     readonly productsOutOfStock = page.getByTestId("out-of-stock-analytics"),
@@ -35,7 +34,6 @@ export class HomePage {
   async expectHomePageElementsToBeVisible() {
     await expect(this.sales).toBeVisible();
     await expect(this.activity).toBeVisible();
-    await expect(this.topProducts).toBeVisible();
     await expect(this.productsOutOfStock).toBeVisible();
   }
 }
diff --git a/playwright/pages/loginPage.ts b/playwright/pages/loginPage.ts
@@ -36,7 +36,8 @@ export class LoginPage {
     await this.typeEmail(userEmail);
     await this.typePassword(userPassword);
     await this.clickSignInButton();
-    await expect(this.homePage.welcomeMessage).toContainText("Hello there,", {
+    // This check shouldn't be tied to user's email or first/last name
+    await expect(this.homePage.welcomeMessage).toContainText("welcome to your Store Dashboard", {
       timeout: 15000,
     });
   }

diff --git a/src/welcomePage/WelcomePageTitle.tsx b/src/welcomePage/WelcomePageTitle.tsx
@@ -9,7 +9,7 @@ export const WelcomePageTitle = () => {
   const userName = getUserName(user, true);
 
   return (
-    <Text as="h1" size={9}>
+    <Text as="h1" size={9} data-test-id="home-header">
       <FormattedMessage
         defaultMessage="Hello {userName}, welcome to your Store Dashboard"
         id="0+zatS"