chm のビルド前に chm ファイルを削除する #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
approved these changes
Jan 20, 2019
| @@ -8,34 +8,29 @@ set HHP_MACRO=help\macro\macro.HHP | |||
| set HHP_PLUGIN=help\plugin\plugin.hhp | |||
| set HHP_SAKURA=help\sakura\sakura.hhp | |||
| ) | ||
| set CHM_MACRO=help\macro\macro.chm | ||
| set CHM_PLUGIN=help\plugin\plugin.chm | ||
| set CHM_SAKURA=help\sakura\sakura.chm |
| ) | ||
| call :BuildChm %HHP_MACRO% %CHM_MACRO% || (echo error && exit /b 1) | ||
| call :BuildChm %HHP_PLUGIN% %CHM_PLUGIN% || (echo error && exit /b 1) | ||
| call :BuildChm %HHP_SAKURA% %CHM_SAKURA% || (echo error && exit /b 1) |
There was a problem hiding this comment.
コメント) 構造は call :BuildChm( str, str )。
引数1と引数2は "%Variable%" とするのがベター。
利用シーンで空白を含まないことが分かっているので対応は不要。
| @@ -23,14 +23,19 @@ exit /b 0 | |||
| :BuildChm | |||
| set PROJECT_HHP=%1 | |||
| set PROJECT_CHM=%2 | |||
|
|
|||
| if exist "%PROJECT_CHM%" del /F "%PROJECT_CHM%" | |||
There was a problem hiding this comment.
コメント) 削除が成功したとき（通常は削除が行われない）に「1個のファイルを削除しました(英語」が出ますね。ファイル名が出ないので、ハマるときはこういうのでもハマりそう。問題ないと思いますが。
| @rem hhc.exe returns 1 on success, and returns 0 on failure | ||
| "%CMD_HHC%" %PROJECT_HHP% | ||
| if not errorlevel 1 ( | ||
| echo error %PROJECT_HHP% errorlevel %errorlevel% | ||
|
|
||
| del /F "%PROJECT_CHM%" |
There was a problem hiding this comment.
コメント) ファイル削除後のエラーチェックはしないんですね 😄
|
マージしちゃいます |
|
コメント全スルーかいっ！ｗ（いいけど。 |
|
approve されたし、ま、いいかと |
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
…handling-chm chm のビルド前に chm ファイルを削除する
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chm のビルド前に chm ファイルを削除する
作業しやすいように最初の commit でリファクリタングしてから、対応を入れています。