Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CodeFactor の badge を追加 #693

Merged
merged 1 commit into from
Dec 12, 2018
Merged

CodeFactor の badge を追加 #693

merged 1 commit into from
Dec 12, 2018

Conversation

m-tmatma
Copy link
Member

CodeFactor の badge を追加
sakura-editor/management-forum#54

@m-tmatma m-tmatma added this to the next release milestone Dec 11, 2018
@m-tmatma m-tmatma added the document ドキュメント label Dec 11, 2018
@m-tmatma
Copy link
Member Author

Show all checks のところをクリックすると CodeFactor の項目が出てきます。
これで No issues found と確認できます。

ここには差分しか表示されません。
全体を見るには、この PR に貼り付けているバッチをクリックするとプロジェクトのサイトに飛びます。

@m-tmatma m-tmatma mentioned this pull request Dec 11, 2018
Closed
beru
beru approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@beru beru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

問題無いと思います。

berryzplus
berryzplus approved these changes Dec 11, 2018
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

対応ありがとうございます。
予想外にシンプルな変更で驚きました。

@m-tmatma m-tmatma merged commit 0c67570 into sakura-editor:master Dec 12, 2018
@m-tmatma m-tmatma deleted the feature/codefactor-badge branch December 12, 2018 10:39
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@m-tmatma
Merge pull request sakura-editor#693 from m-tmatma/feature/codefactor…
1599212 
…-badge

CodeFactor の badge を追加
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beru beru beru approved these changes

@berryzplus berryzplus berryzplus approved these changes

Assignees
No one assigned
Labels
document ドキュメント
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
3 participants
@m-tmatma @beru @berryzplus