Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

関数ポインタの値ではなくてアドレスをテーブルに登録するように修正 #644

Merged
merged 1 commit into from
Nov 24, 2018
Merged

関数ポインタの値ではなくてアドレスをテーブルに登録するように修正 #644

merged 1 commit into from
Nov 24, 2018

Conversation

beru
Copy link
Contributor

@beru beru commented Nov 24, 2018

#643 への対処です。

berryzplus
berryzplus approved these changes Nov 24, 2018
View reviewed changes
Copy link
Contributor

@berryzplus berryzplus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMです。

@beru beru merged commit 99a7601 into sakura-editor:master Nov 24, 2018
@beru beru deleted the m_pfnHtmlHelp_nullptr branch November 24, 2018 10:41
@beru beru mentioned this pull request Nov 24, 2018
Closed
@m-tmatma m-tmatma added this to the next release milestone Dec 1, 2018
@KENCHjp KENCHjp added the refactoring リファクタリング 【ChangeLog除外】 label Dec 11, 2018
HoppingTappy pushed a commit to HoppingTappy/sakura that referenced this pull request Jun 11, 2019
@beru
Merge pull request sakura-editor#644 from beru/m_pfnHtmlHelp_nullptr
01af0be 
関数ポインタの値ではなくてアドレスをテーブルに登録するように修正
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berryzplus berryzplus berryzplus approved these changes

Assignees
No one assigned
Labels
refactoring リファクタリング 【ChangeLog除外】
Projects
None yet
Milestone
v2.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@beru @berryzplus @m-tmatma @KENCHjp