artifacts の名前に appveyor の名前を含める (構成要素の順序調整) #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ただし APPVEYOR_ACCOUNT_NAME の環境変数が空の場合または "sakuraeditor" と等しい場合は何もつけない。
|
最終的なコミットでは appveyor.yml の先頭に "*" を付ける必要はありませんが、 |
berryzplus
reviewed
Jul 8, 2018
appveyor.yml
Outdated
| @@ -21,4 +21,4 @@ build_script: | |||
| echo appveyor_yml | |||
|
|
|||
| artifacts: | |||
| - path: 'sakura-$(platform)-$(configuration)*.zip' | |||
| - path: '*sakura-*$(platform)-$(configuration)*.zip' | |||
There was a problem hiding this comment.
コメントで言及してるのはこれのことですか？
zipの出力先をルートにしたから*は要らない、と。
分かっている内容なら削除したほうがいいような気もしますが、直すまでもないと思います。
There was a problem hiding this comment.
後で必要になるかも、というのがあったので残しておきました。
d2c8255 で削除しました。
berryzplus
approved these changes
Jul 8, 2018
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 11, 2019
…or-username-to-artifacts artifacts の名前に appveyor の名前を含める (構成要素の順序調整)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
artifacts の名前に appveyor の名前を含める (構成要素の順序調整)
以下の表の順番で構成する。
影響範囲