全角幅が半角幅の2倍にならない場合の補正機能をテストするコードの追加 #1920
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
✅ Build sakura 1.0.4289 completed (commit 3a4edf2bff by @berryzplus) |
beru
reviewed
Jun 6, 2023
| @@ -39,6 +39,12 @@ class CharWidthCache : public testing::Test { | |||
| lf2 = LOGFONT(); | |||
| lf2.lfCharSet = DEFAULT_CHARSET; | |||
| std::wcscpy(lf2.lfFaceName, L"Meiryo"); | |||
| lf3 = LOGFONT(); | |||
| lf3.lfCharSet = DEFAULT_CHARSET; | |||
| std::wcscpy(lf3.lfFaceName, L"MS Gothic"); // UD デジタル 教科書体 N-B | |||
There was a problem hiding this comment.
CIが実行される環境だとコメントにあるフォントがインストールされていないんですねきっと。
フォントがインストールされているかWindowsAPIを呼んで調べるのはちょっと億劫ですね。
https://learn.microsoft.com/en-us/windows/win32/gdi/enumerating-the-installed-fonts
There was a problem hiding this comment.
削り忘れですね。
PRマージ時に確認したフォントは「UD デジタル 教科書体 N-B」ですが、GitHub Actionsで利用できないようなので英語版Windowsでも標準イントールされるフォントでテストするように変更しました。
実害はないのでこのままマージしてしまいます。
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR対象
カテゴリ
PR の背景
仕様・動作説明
PR の影響範囲
テスト内容
関連 issue, PR
参考資料