Revert change at #1512 partially #1830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
N_SHAREDATA_VERSIONの修正ミスを訂正します。 SonarCloudの指摘に従ってdefineをconstexprに置換しましたが、既存のCマクロに悪影響が出るので元に戻します。
|
Kudos, SonarCloud Quality Gate passed!
|
|
✅ Build sakura 1.0.4103 completed (commit 70face0392 by @sanomari) |
beru
approved these changes
May 1, 2022
berryzplus
approved these changes
May 2, 2022
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
N_SHAREDATA_VERSIONの修正ミスを訂正します。
カテゴリ
PR の背景
SonarCloudの指摘に従ってdefineをconstexprに置換しましたが、既存のCマクロに悪影響が出るので元に戻します。
PR のメリット
PR のデメリット (トレードオフとかあれば)
仕様・動作説明
SonarCloudの指摘に従ってdefineをconstexprに置換しましたが、既存のCマクロに悪影響が出るので元に戻します。
PR の影響範囲
マクロでN_SHAREDATA_VERSIONの値を展開している箇所が、
値ではなくN_SHAREDATA_VERSIONという文字列に展開されていました。
サクラエディタ自体には機能的な実害はありませんが、後世のために修正しておきたいです。
テスト内容
テスト1
手順
関連 issue, PR
参考資料