不要なバッチ変数を削除する #1758
Merged
不要なバッチ変数を削除する #1758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
|
❌ Build sakura 1.0.3983 failed (commit 2ca9ce57c8 by @berryzplus) |
ghost
mentioned this pull request
|
CIが失敗していますが、PRの変更とは関係なさそうなので大丈夫でしょう。 |
|
❌ Build sakura 1.0.3983 failed (commit 2ca9ce57c8 by @berryzplus) |
ghost
mentioned this pull request
|
レビューありがとうございます。マージしちゃいます。 ビルドエラーはヘルプビルドのためのLeProcがらみなので問題ないと思います。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
ビルドで使うバッチファイル内に不要な変数が定義されていたのを削除します。
カテゴリ
PR の背景
#1755 (comment)
PR のメリット
未使用の不要変数を削除することにより、バッチコードが読みやすくなります。
PR のデメリット (トレードオフとかあれば)
パッと見で明らかなミス（≒削除漏れ）と判断していますが、
何か魔法のような方法でビルドシステムに影響を与えるかも知れません。
仕様・動作説明
PR の影響範囲
MSVCによるビルドに影響する変更です。
テスト内容
テスト1
手順
関連 issue, PR
参考資料