SonarScanにモジュールを検索を導入する #1668
Merged
SonarScanにモジュールを検索を導入する #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
berryzplus
force-pushed
the
feature/find_module_for_sonarscan
branch
from
db524d6
to
a4b3fd1
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
|
powershellワンライナー(改行あり)を |
kengoide
approved these changes
May 10, 2021
|
レビューありがとうございます。マージしちゃいます。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
タイトル通りです。
カテゴリ
PR の背景
#1660 でテストモジュールのパスを変更した際に、SonarScanが動かない問題が発生したので対策します。
PR のメリット
PR のデメリット (トレードオフとかあれば)
仕様・動作説明
SonarScanで実行するモジュールのパス記述方法を変更します。
従来： sonarscan.ymlにベタ書き
PR後： SonarScan実行時に検索
PR の影響範囲
SonarScanに影響する変更です。
テスト内容
このPR変更は master にマージして初めて効果を発動します。
別リポジトリの mster に push して検索が実行されることを確認しました。
https://github.com/berryzplus/sakura/runs/2544465859?check_suite_focus=true
関連 issue, PR
参考資料