単体テストコードの記述ミスを訂正する #1611
Merged
単体テストコードの記述ミスを訂正する #1611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
constexpr const wchar_t* str = L"hoge"; とすべきところ、以下のようにしていた。 constexpr wchar_t* str = L"hoge";
|
Kudos, SonarCloud Quality Gate passed!
|
|
✅ Build sakura 1.0.3619 completed (commit 3df2047c65 by @berryzplus) |
sanomari
approved these changes
Mar 28, 2021
|
レビューありがとうございます。マージしちゃいます。 |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
タイトル通りです。
カテゴリ
PR の背景
単体テストのコード記述が c++ 的に正しくないのに気付きました。
constexpr const wchar_t* str = L"hoge";とすべきところ、以下のようにしています。
constexpr wchar_t* str = L"hoge";MinGWビルドのコンソールを見ていて気付きました。
意外と、誰も見てないのかも知れないです。
PR のメリット
PR のデメリット (トレードオフとかあれば)
仕様・動作説明
PR の影響範囲
テスト内容
テスト1
手順
関連 issue, PR
#1579
参考資料