-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
正規表現キーワードのインポートで許容サイズを超える文字列を無駄にコピーしているのを修正する #1244
Merged
berryzplus
merged 5 commits into
sakura-editor:master
from
berryzplus:feature/amend_pr1034_buffer_size_limitation
Apr 26, 2020
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -661,21 +661,27 @@ bool CImpExpRegex::Import( const wstring& sFileName, wstring& sErrMsg ) | |
} | ||
if( k != -1 ) /* 3文字カラー名からインデックス番号に変換 */ | ||
{ | ||
if( 0 < MAX_REGEX_KEYWORDLISTLEN - keywordPos - 1 ){ | ||
// pKeywordに書き込める上限サイズ(NUL終端分を含む) | ||
const size_t cchAvailableSize = std::min<size_t>( MAX_REGEX_KEYWORDLEN, MAX_REGEX_KEYWORDLISTLEN - 1 - keywordPos ); | ||
|
||
// 書き込み上限を指定して文字列コピーし、処理結果を受け取る | ||
auto ncpyResult = ::wcsncpy_s( &pKeyword[keywordPos], cchAvailableSize, p, _TRUNCATE ); | ||
if( ncpyResult == 0 ){ | ||
regexKeyArr[count].m_nColorIndex = k; | ||
wcsncpy_s( &pKeyword[keywordPos], MAX_REGEX_KEYWORDLISTLEN - keywordPos, p, _TRUNCATE ); | ||
count++; | ||
keywordPos += wcsnlen( &pKeyword[keywordPos], MAX_REGEX_KEYWORDLISTLEN - keywordPos ) + 1; | ||
keywordPos += wcsnlen( &pKeyword[keywordPos], cchAvailableSize) + 1; | ||
}else{ | ||
// L"キーワード領域がいっぱいなため切り捨てました。" | ||
sErrMsg = LS(STR_IMPEXP_REGEX2); | ||
} | ||
} | ||
}else{ | ||
// L"不正なキーワードを無視しました。" | ||
sErrMsg = LS(STR_IMPEXP_REGEX3); | ||
} | ||
} | ||
} | ||
pKeyword[keywordPos] = L'\0'; | ||
pKeyword[keywordPos] = L'\0'; // 2個目のNUL終端を書き込む | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 必ずしも2個目ではありません。 |
||
|
||
in.Close(); | ||
|
||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
変数名とコメントが嘘です。MAX_REGEX_KEYWORDLEN は pKeyword からくる制約ではありません。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
符号なし整数に負の値を設定しようとするケースがあります。
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
考えてなかったです。