バージョン情報に表示するプロジェクトURLに付けるラベルキャプションを短くする #1215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
表示する文字列が長過ぎてラベルが見切れてしまっていることの対策。 変更前： Project sakura-editor: 変更後： Project URL:
|
❌ Build sakura 1.0.2655 failed (commit 8a8fa5106f by @berryzplus) |
|
✅ Build sakura 1.0.2656 completed (commit 8a8fa5106f by @berryzplus) |
m-tmatma
approved these changes
Mar 16, 2020
HoppingTappy
pushed a commit
to HoppingTappy/sakura
that referenced
this pull request
Jun 16, 2020
…_label バージョン情報に表示するプロジェクトURLに付けるラベルキャプションを短くする
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR の目的
バージョン情報ダイアログに表示しているプロジェクトサイトURLに付けたラベルで、ラベル文字列が長過ぎることによる見切れた発生しとります。
PR適用前の比較的新しいPRビルド
安直ですが、ラベルを短くすることにより、この問題に対処したいです。
Project sakura-editor:Project URL:カテゴリ
動作には影響しませんが、見方によっては「不具合修正」に当たるかも知れません。
PR の背景
#1201 参照。
PR のメリット
PR のデメリット (トレードオフとかあれば)
Project SAKURA-Editor:が正しい表記のような気がします。PR の影響範囲
関連チケット
#1201
参考資料