Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve list helpers #81

Merged
merged 4 commits into from
Aug 24, 2017
Merged

Improve list helpers #81

merged 4 commits into from
Aug 24, 2017

Conversation

silverman63
Copy link
Contributor

@silverman63 silverman63 commented Aug 15, 2017 •
edited
Loading

Adds get_vars optional arg to getList

@silverman63 silverman63 requested a review from robwil August 15, 2017 19:56
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.4%) to 18.042% when pulling 3b68088 on AddVarsToListFunctions into 43fb5a6 on 2.0.

robwil
robwil reviewed Aug 15, 2017
View reviewed changes
sailthru/Sailthru_Client.php Outdated
if ($type) {
$data['type'] = $type;
}
if ($primary === null) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should this be $primary !== null ?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.3%) to 18.217% when pulling f6b0f4f on AddVarsToListFunctions into 43fb5a6 on 2.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 18.324% when pulling 4dcca6c on AddVarsToListFunctions into 43fb5a6 on 2.0.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.2%) to 18.288% when pulling c0fc9a5 on AddVarsToListFunctions into 43fb5a6 on 2.0.

@silverman63 silverman63 merged commit 4a62149 into 2.0 Aug 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robwil robwil robwil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@silverman63 @coveralls @robwil