Remove setting special viewport in desktop mode. JB#57542 #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a part of fixes for JB#57542, another part you can find here: sailfishos/sailfish-components-webview#153
As for this part, we found that when switching to desktop mode gecko changes its viewport to a value that corresponds the DevicePixelRatio (DPR) value of ~2.1, regardless of what the DPI value of screen is. In the other part of fixes we implemented mechanism that calculates DPR value depending of screen DPI, and for example for 1920x1200 10 inch screen the DPR value will be 1.5. So, after we switch to desktop mode, the DPR value increases to ~2.1 and the elements on the page become bigger, than in mobile version. But many desktop web-pages are designed, on the contrary, for lower DPI values (on desktop it is usually 1.0) and smaller element size. So we suggest to stick to the middle option and leave the DPR and viewport unchanged when switching to desktop mode, so as our colleagues from Yandex browser for Android (100M+ installs) do.