Fix for files that are rotated after resizing

[adamivancza]

Example image to reproduce the issue:
http://smartuploader.s3-website-us-east-1.amazonaws.com/uploads/sizes/1548235941338/0ca4075d-4039-4fbe-8341-32f0ee75a2a2.jpeg

[sagidM]

Hi Adam

Thank you for contributing.
I will look through your suggestion later on.

[sagidM]

Because of your contribution, we are going to avoid deprecated methods. Which means s3-resizer is still supported.
I also see that this repository helps people and it really makes me happy.
Thank you again!

[sagidM]

v0.21 Changelog says that .withoutEnlargement, .max, and .min are deprecated.
It seems we need to change .resize method above on :L30 to
.resize(..., ..., {withoutEnlargement: true, fit}).
Where fit is null | 'inside' | 'outside'. I.e.

var fit;
switch (func) {
  case 'max': fit = 'inside'; break;
  case 'min': fit = 'outside'; break;
  case null: fit = null; break;
  default: // ...
}

And could you please explain why should we have calling .rotate() here?

[adamivancza]

Sure thing - will do those changes. rotate function should rotate the image according to EXIF info: https://sharp.pixelplumbing.com/en/stable/api-operation/#rotate. the image I've attached is from an Android device - when you view the original image it's in portrait. but when I've resized it with your library it's resized to a landscape image. to fix this I've added the portrait call - that will rotate the image back to original position using EXIF info.

[sagidM]

I intentionally have written the value that way.
Firstly, it's red and captures a look immediately.
Secondly, even if a user copies and pastes it as it is, it is invalid json, so it is going to throw an error.

However, in case you are able to give a good explanation why the changed code is better, we can continue.

[adamivancza]

ah I see - it caused me an invalid JSON as well that's why I wanted to fix it. But your reasoning makes sense! I'll revert that change :)

[adamivancza]

updated my PR @sagidM

[sagidM]

It seems you've forgotten to use func, removing case clause =)
https://github.com/sagidM/s3-resizer/blob/f49db24ef16d436d9cedfe3a4e3fa995a5982eb6/index.js
(options must contain fit; max => 'inside', min => 'outside')

Since in one-line object there's no spaces, it contrasts using spaces in one place.
{myObject: '!'}, { yourObject: '!' }

---

By the way, I don't remember why I chose that name; would not it be better to rename func => action?
What do you think?

[adamivancza]

ohhh right - I've added that missing handler for func. Yeah that was a good shout to rename func to action - definitely makes more sense that way :)

[sagidM]

Okay, we have done here.
I will update setting up instructions and upload a new release later on.
Thank you very much Adam!

[sagidM]

Did that by mistake...

[adamivancza]

Awesome - thanks for all the suggestions on the PR :)