Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for 3.12, drop EOL 3.7 #188

Merged
merged 5 commits into from
Oct 6, 2023

Conversation

Jackenmen
Copy link
Contributor

3.12 untested, we'll see if the tests succeed or if there's more work needed. Dropping 3.7 as well since it's way past EOL.

@Jackenmen
Copy link
Contributor Author

Looks like it all passes and builds the right wheels! Leaving this as a draft since if you don't get to it within a few days, there are probably going to be version bumps needed for the Python version specified in the setup-python action and cibuildwheel version.

@saghul
Copy link
Owner

saghul commented Oct 2, 2023

Thank you!

@Jackenmen
Copy link
Contributor Author

I'm going to note that you can build wheels with RC versions of Python since they're the point at which there are no more ABI changes being made. So if you do happen to have time to cut a release sooner, you can do so safely with the current state of PR as well.

@Jackenmen Jackenmen marked this pull request as ready for review October 6, 2023 06:01
@Jackenmen
Copy link
Contributor Author

Alright, I updated the PR to use stable Python 3.12 and updated cibuildwheel with the version using 3.12.0 for builds as well.

@saghul saghul merged commit bc7630f into saghul:master Oct 6, 2023
20 checks passed
@Jackenmen Jackenmen deleted the drop-3.7-add-3.12 branch October 6, 2023 06:56
@saghul
Copy link
Owner

saghul commented Oct 6, 2023

Cheers! I'll cut out a release now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants