This repository was archived by the owner on Jun 18, 2020. It is now read-only.
Jmol enhancements from Sage trac 12299 #64
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
I didn't realize that the previous one had the wrong dates and author, so thank you very much for preserving gutow's considerable contributions here. |
Member
|
Just FYI, #12299 should now have positive review, so you can feel free to merge this if it is convenient - which it may not be, just be sure to mark on that Sage ticket which sagenb spkg you would do that in (I'm marking it as sage-pending for now). |
Collaborator
Author
|
I'll merge it when I get back home later today. Expect it in sagenb 0.9.1, |
kini
added a commit
that referenced
this pull request
Jun 20, 2012
Jmol enhancements from Sage trac 12299
Collaborator
Author
|
Merged! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to @kcrisman at #61 for doing this in the first place. I've made this branch by more directly importing @gutow's patches, i.e. so that he is listed as the author, and so that the commit dates are correctly recorded.