Redirection doesn't work when logged in

[gvol]

If you are logged in and open a URL like

http://localhost:8080/?next=http%3A%2F%2Flocalhost%3A8080%2Fupload_worksheet%3Furl%3Dfile%3A%2F%2F%2FUsers%2Fgvol%2FSageStuff%2FGAP%2520test.sws 

then it will simply redirect to the "home page" i.e. http://localhost:8080/home/admin/ instead of the ?next= page, in this case uploading a sws file.

This causes problems when starting a server and uploading a file at the same time since there is a race condition in which login can happen too late for the page itself to work, and too early for the ?next= page to work. See comments on issue #31.

[kcrisman]

I haven't seen this, so I can't review this, but this certainly seems to be a likely fix.

[jhpalmieri]

With this, I still get two browser windows open, but one of them does have the uploaded worksheet. The other opens to http://localhost:8080/home/admin/.

[kcrisman]

With this, I still get two browser windows open, but one of them does have the uploaded worksheet.

Good. I don't know if there is much one can do about the two windows, or at least it's not necessarily part of this ticket - Sage just automatically starts a window no matter what other things one is doing when one starts up with login, right, Ivan?

[gvol]

Opening two windows is by "design". Which is to say that when the server starts (not uploading) it opens a window, and I just wanted to open another one. The options have changed somewhat since I originally created the patch. In particular open_viewer has been changed to automatic_login, but of course the semantics have changed a little bit. Now it may not (or it may still) make sense to open 2 windows. It might require a little work to deal with startup tokens and redirecting correctly, but it should be fairly easy. I haven't thought much about which I would prefer as a user, but I presume opening one window.

[jhpalmieri]

I think this works well enough now to be merged. The one vs. two window situation can be dealt with separately. (I think that opening two windows when given an "upload" argument will not be what most users expect, so I would prefer one window. But I don't have strong feelings about it.)

[kcrisman]

So it sounds like this should be closed when #78 is merged. Also should be included in 0.10.0 at http://trac.sagemath.org/sage_trac/ticket/13121.