Skip to content

Deprec after 38184#41542

Merged
vbraun merged 2 commits intosagemath:developfrom
fchapoton:deprec_after_38184
Feb 1, 2026
Merged

Deprec after 38184#41542
vbraun merged 2 commits intosagemath:developfrom
fchapoton:deprec_after_38184

Conversation

@fchapoton
Copy link
Copy Markdown
Contributor

clean after #38184, closed in 2024

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.

@vincentmacri
Copy link
Copy Markdown
Member

I think you accidentally included your commit from #41541 on this branch.

@fchapoton
Copy link
Copy Markdown
Contributor Author

indeed, sorry. fixed now

@vincentmacri
Copy link
Copy Markdown
Member

LGTM. Unless CI finds something wrong I'll set to positive review.

@vincentmacri
Copy link
Copy Markdown
Member

There are indeed relevant failures. Make sure to remove the deprecated methods from the corresponding .pyd files as well. Also from the .pyi files, although CI doesn't check it for .pyi files.

@github-actions
Copy link
Copy Markdown

Documentation preview for this PR (built with commit 2bc6769; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@vbraun vbraun merged commit affbd95 into sagemath:develop Feb 1, 2026
25 of 28 checks passed
@fchapoton fchapoton deleted the deprec_after_38184 branch February 2, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants