Refactor generic ideal method + avoid computing principal generator of ideal of PolynomialRing on construction#41425
Draft
user202729 wants to merge 3 commits intosagemath:developfrom
Draft
Conversation
|
Documentation preview for this PR (built with commit 0e6f5fe; changes) is ready! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.gcd()is ran for univariate polynomial ring.Reason:
There's a doctest
that now takes very long to run. With this change, the runtime is cut in half. (Finding a single generator for a number field ideal is usually harder than finding a HNF basis of the ideal, and the latter is all pari needs to do relevant computations.)
Note: this is kind of a breaking change, in that
ZZ.ideal(1, 2, 3).gens()will now return(1, 2, 3). I think it is preferable (users who want reduced generators can rungens_reduced).Indeed, some tests break https://github.com/sagemath/sage/actions/runs/20863923668/job/59950182623 --- but ideally they should be refactored to avoid relying specifically on this behavior.
📝 Checklist
⌛ Dependencies