Skip to content

Ensuring PALP fails consistently without returning misleading data #41414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbraun merged 6 commits into from
Jan 14, 2026
Merged

Ensuring PALP fails consistently without returning misleading data #41414

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
609272c
fix bug in Lattice Polytopes #41400
rashadalsharpini Jan 8, 2026
02c67e0
Simplified code structure and removed unnecessary exception reraising
rashadalsharpini Jan 9, 2026
68a4377
add doctest, fix typos
rashadalsharpini Jan 10, 2026
c0906c3
rst syntax fix
rashadalsharpini Jan 10, 2026
78ccab6
Add additional doctest to confirm consistent failure
rashadalsharpini Jan 12, 2026
aa049b7
describing the doctest better
rashadalsharpini Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
93 changes: 66 additions & 27 deletions src/sage/geometry/lattice_polytope.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3717,37 +3717,76 @@ def points(self, *args, **kwds):
sage: p.points()
M(1)
in 1-d lattice M

Regression test: ensure this method does not cache an incorrect answer
when an exception is raised. This 6-dimensional polytope exceeds PALP's
internal limits and should raise RuntimeError, not returning wrong results
(:issue:`41400`)::

sage: V = [(-1, -1, 0, 0, 0, 0),
....: (-1, 0, 0, 0, 0, 0),
....: (-1, -1, -1, 0, 0, 0),
....: (-1, -1, -1, -1, 0, 0),
....: (-1, -1, -1, 0, -1, 0),
....: (-1, -1, -1, -1, -1, 0),
....: (-1, -1, -1, -1, -1, -1),
....: (-1, -1, -1, 0, -1, -1),
....: (0, 0, 0, 1, 0, 0),
....: (0, 1, 0, 0, 0, 0),
....: (1, 0, 0, 0, 0, 0),
....: (0, 0, 1, 0, 0, 0),
....: (0, 0, 0, 0, 1, 0),
....: (0, 0, 0, 0, 0, 1)]
sage: Q = LatticePolytope(V)
sage: Q.points() # needs palp
Traceback (most recent call last):
...
RuntimeError: Error executing ...
Output:
...Transpose_PM failed...
sage: Q.points() # needs palp
Traceback (most recent call last):
...
RuntimeError: Error executing ...
Output:
...Transpose_PM failed...
"""
if not hasattr(self, "_points"):
M = self.lattice()
nv = self.n_vertices()
self._points = points = self._vertices
if self.dim() == 1:
v = points[1] - points[0]
l_gcd = gcd(v)
if l_gcd > 1:
v = M(v.base_extend(QQ) / l_gcd)
if hasattr(self, "_points"):
if args or kwds:
return self._points(*args, **kwds)
else:
return self._points
M = self.lattice()
nv = self.n_vertices()
points = self._vertices
if self.dim() == 1:
v = points[1] - points[0]
l_gcd = gcd(v)
if l_gcd > 1:
v = M(v.base_extend(QQ) / l_gcd)
points = list(points)
current = points[0]
for i in range(l_gcd - 1):
current += v
current.set_immutable()
points.append(current)
if self.dim() > 1:
result = self.poly_x("p", reduce_dimension=True)
if self.dim() == self.lattice_dim():
points = read_palp_point_collection(StringIO(result), M)
else:
m = self._embed(read_palp_matrix(result))
if m.ncols() > nv:
points = list(points)
current = points[0]
for i in range(l_gcd - 1):
current += v
for j in range(nv, m.ncols()):
current = M.element_class(
Comment thread
rashadalsharpini marked this conversation as resolved.
M, [m[i, j] for i in range(M.rank())])
current.set_immutable()
points.append(current)
if self.dim() > 1:
result = self.poly_x("p", reduce_dimension=True)
if self.dim() == self.lattice_dim():
points = read_palp_point_collection(StringIO(result), M)
else:
m = self._embed(read_palp_matrix(result))
if m.ncols() > nv:
points = list(points)
for j in range(nv, m.ncols()):
current = M.element_class(
M, [m[i, j] for i in range(M.rank())])
current.set_immutable()
points.append(current)
if len(points) > nv:
self._points = PointCollection(points, M)
if len(points) > nv:
self._points = PointCollection(points, M)
else:
self._points = points
if args or kwds:
return self._points(*args, **kwds)
else:
Expand Down
Loading