remove some deprecated stuff in topology/#41406
Merged
vbraun merged 3 commits intosagemath:developfrom Jan 14, 2026
Merged
Conversation
|
Documentation preview for this PR (built with commit 2ac3168; changes) is ready! 🎉 |
dcoudert
reviewed
Jan 8, 2026
| """ | ||
| v = [self._vertex_dictionary[i[0]] for i in self.domain().faces()[0]] | ||
| return all(v.count(i) <= 1 for i in v) | ||
| return all(v.count(i) <= 1 for i in v) # todo better |
Contributor
There was a problem hiding this comment.
some alternative solutions with better time complexity:
- sort
vand then check whetherv[i] != v[i+1]for allI - compare
len(v) == len(set(v))
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 13, 2026
sagemathgh-41406: remove some deprecated stuff in topology/ after sagemath#37922 ; Closed Date: 2024-05-25 sagemath#38103 ; Closed Date: 2024-06-09 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41406 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
after
#37922 ; Closed Date: 2024-05-25
#38103 ; Closed Date: 2024-06-09
📝 Checklist