Require Python 3.12 or newer; remove outdated workarounds by tobiasdiez · Pull Request #40936 · sagemath/sage

tobiasdiez · 2025-09-30T17:05:21Z

In line with Spec 0, we remove support for Python 3.11. Many outdated patches/workarounds for these older (or even older) Python versions are removed, but I cannot guarantee that I've found all obsolete ones. Also CI tests for systems using Python 3.11 are removed.

For next years cleaning job:

Change version in pyproject.toml and build/pkgs/python3/spkg-configure.m4
Search for 3.12, 312,3,12, PY_VERSION, PY_MINOR_VERSION and sys.version_info

Similar PRs:

Require Python 3.11 or newer; remove outdated workarounds #39251

📝 Checklist

The title is concise and informative.
The description explains in detail what this PR is about.
I have linked a relevant issue or discussion.
I have created tests covering the changes.
I have updated the documentation and checked the documentation preview.

⌛ Dependencies

Conda: support Python 3.13 #39163

github-actions · 2025-09-30T18:17:12Z

Documentation preview for this PR (built with commit 6bb49a8; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

tobiasdiez · 2025-11-01T02:53:02Z

Failure in the pdf docs seems to be unrelated (so are the other CI failures)

cxzhong · 2025-11-01T03:34:11Z

You should delete 3.11 conda ci

tobiasdiez · 2025-11-01T03:54:33Z

You should delete 3.11 conda ci

I think I did this already, but might have missed something. What do you mean precisely?

cxzhong · 2025-11-01T06:21:31Z

You should delete 3.11 conda ci

I think I did this already, but might have missed something. What do you mean precisely?

In ci-meson.yml, you should delete the 3.11 conda ci

cxzhong · 2025-11-01T08:32:41Z

You should delete 3.11 conda ci

I think I did this already, but might have missed something. What do you mean precisely?

In ci-meson.yml, you should delete the 3.11 conda ci

You need to delete

 include:
          # One run for oldest supported Python
          - os: 'ubuntu'
            python: '3.11'
            tests: 'all'

This provides support for Python 3.14, and drops Python 3.11 ### 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies    - sagemath#40936: needed for CI to pass URL: sagemath#41116 Reported by: Dima Pasechnik Reviewer(s): Chenxin Zhong

dimpase · 2025-11-04T15:34:36Z

@cxzhong

You should delete 3.11 conda ci

I think I did this already, but might have missed something. What do you mean precisely?

In ci-meson.yml, you should delete the 3.11 conda ci

You need to delete
 include:
          # One run for oldest supported Python
          - os: 'ubuntu'
            python: '3.11'
            tests: 'all'

will

--- a/.github/workflows/ci-meson.yml
+++ b/.github/workflows/ci-meson.yml
@@ -35,7 +35,7 @@ jobs:
         include:
           # One run for oldest supported Python
           - os: 'ubuntu'
-            python: '3.11'
+            python: '3.12'
             tests: 'all'
           # Test only changed files
           - os: 'ubuntu'

do?

cxzhong · 2025-11-04T15:38:06Z

@cxzhong

You should delete 3.11 conda ci

I think I did this already, but might have missed something. What do you mean precisely?

In ci-meson.yml, you should delete the 3.11 conda ci

You need to delete
 include:
          # One run for oldest supported Python
          - os: 'ubuntu'
            python: '3.11'
            tests: 'all'

will

--- a/.github/workflows/ci-meson.yml
+++ b/.github/workflows/ci-meson.yml
@@ -35,7 +35,7 @@ jobs:
         include:
           # One run for oldest supported Python
           - os: 'ubuntu'
-            python: '3.11'
+            python: '3.12'
             tests: 'all'
           # Test only changed files
           - os: 'ubuntu'

do?

yes. Because in this PR, all conda lock files about python 3.11 are deleted. It is failed.

dimpase · 2025-11-04T15:39:03Z

also, how about removing build/pkgs/_python3.11/ ?

cxzhong · 2025-11-04T15:40:06Z

also, how about removing build/pkgs/_python3.11/ ?

I do not know this. I think these files are not useful. But I can not confirm

dimpase · 2025-11-04T15:48:02Z

there is also build/pkgs/exceptiongroup/ overdue to remove, as it's only installed for Python version <3.11, see
build/pkgs/exceptiongroup/version_requirements.txt exceptiongroup; python_version<"3.11"

dimpase · 2025-11-04T16:13:20Z

also to remove:

   importlib_metadata
   importlib_resources
   typing_extensions

according to build/pkgs/typing_extensions/spkg-configure.m4 and src/doc/en/developer/coding_in_python.rst

cxzhong · 2025-11-04T16:15:11Z

also to remove:
   importlib_metadata
   importlib_resources
   typing_extensions
according to build/pkgs/typing_extensions/spkg-configure.m4 and src/doc/en/developer/coding_in_python.rst

typing_extensions is a dependency for newer version of beatifulsoup4. We can not remove this

dimpase · 2025-11-04T17:10:11Z

it might be listed in our settings as a dependency, but it's not even installed with python 3.12+, as far as I can see

cxzhong · 2025-11-04T17:17:18Z

it might be listed in our settings as a dependency, but it's not even installed with python 3.12+, as far as I can see

Because in sage-distro We use a old version bs4. You can download the tar ball and look the pyproject.toml

dimpase · 2025-11-04T17:24:34Z

it might be listed in our settings as a dependency, but it's not even installed with python 3.12+, as far as I can see

Because in sage-distro We use a old version bs4. You can download the tar ball and look the pyproject.toml

I just checked this - sorry, you are right. Indeed they still use typing_extensions unconditionally (even in the master branch). Probably all typing_extensions there can be replaced by typing, but OK...

sagemathgh-41116: bump cysignals to 1.12.6, cypari to 2.2.4 This provides support for Python 3.14, and drops Python 3.11 ### 📝 Checklist  - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies    - sagemath#40936: needed for CI to pass URL: sagemath#41116 Reported by: Dima Pasechnik Reviewer(s): Chenxin Zhong

cxzhong · 2025-11-14T06:51:32Z

@tobiasdiez Reslove conflict and merge the lastest develop please.

cxzhong · 2025-11-17T23:52:08Z

src/sage/cpython/atexit.pyx

-
-    #if PY_VERSION_HEX >= 0x030e0000
-    // Python 3.14+: atexit uses a PyList
-    static PyObject* get_atexit_callbacks_list(PyObject *self) {


This change is not correct

030e is python 3.14

what is the correct one then?

is this (correct) change something already merged?

yes，it is correct already

is this (correct) change something already merged?

I have fixed it last time. to make it run in python 3.14

should be fixed by a70ec5a - I've put the author as you; this is basically the diff of this file with the 10.8.beta9 version

cxzhong · 2025-11-20T05:52:53Z

change

# One run for oldest supported Python
          - os: 'ubuntu'
            python: '3.11'
            tests: 'all'

in ci-menson.yml

cxzhong · 2025-11-20T05:53:22Z

@cxzhong

You should delete 3.11 conda ci

I think I did this already, but might have missed something. What do you mean precisely?

In ci-meson.yml, you should delete the 3.11 conda ci

You need to delete
 include:
          # One run for oldest supported Python
          - os: 'ubuntu'
            python: '3.11'
            tests: 'all'

will

--- a/.github/workflows/ci-meson.yml
+++ b/.github/workflows/ci-meson.yml
@@ -35,7 +35,7 @@ jobs:
         include:
           # One run for oldest supported Python
           - os: 'ubuntu'
-            python: '3.11'
+            python: '3.12'
             tests: 'all'
           # Test only changed files
           - os: 'ubuntu'

do?

You forget this @dimpase You just delete this. because we already have python3.12 Ubuntu test

Removed configuration for Python 3.11 from CI workflow.

cxzhong · 2025-11-20T06:13:36Z

I have made a PR to this branch. Besides, can we remove check update-menson workflow?

Remove Python 3.11 from CI configuration

cxzhong · 2025-11-20T16:16:58Z

Then wait for CI agree this

dimpase · 2025-11-20T23:13:47Z

now I'm not 100% sure that [./tools/update-meson.py](https://github.com/sagemath/sage/pull/40936/commits/84f27b87a8df3ed752bd8b5532e0d10bb8fafd25) is correct thing for non-Conda installs, but let's see

tobiasdiez · 2025-11-21T16:14:30Z

Tests are passing now, modulo the known random failures.

dimpase · 2025-11-21T19:00:47Z

I think the instructions from tools/update_meson should mention that they apply to Conda venvs only.

cxzhong · 2025-11-22T05:58:59Z

Can we add python 3.14 support before the 10.8 stable version?

tobiasdiez · 2025-11-22T07:47:28Z

I think the instructions from tools/update_meson should mention that they apply to Conda venvs only.

It's not conda specific. But the test that update_meson was run is only part of the conda tests.

dimpase · 2025-11-23T15:33:52Z

I think the instructions from tools/update_meson should mention that they apply to Conda venvs only.

It's not conda specific. But the test that update_meson was run is only part of the conda tests.

perhaps I'm not well-informed on the current coding practices, but are you saying that tools/update_meson must be run on every potential PR which changes a meson.build file? Is this documented?

tobiasdiez · 2025-11-24T20:06:12Z

I think the instructions from tools/update_meson should mention that they apply to Conda venvs only.

It's not conda specific. But the test that update_meson was run is only part of the conda tests.

perhaps I'm not well-informed on the current coding practices, but are you saying that tools/update_meson must be run on every potential PR which changes a meson.build file? Is this documented?

If you add a python/cython file, it needs to be added to the meson file. This test is there to check that this was done.

sagemathgh-40936: Require Python 3.12 or newer; remove outdated workarounds       In line with [Spec 0](https://scientific- python.org/specs/spec-0000/#drop-schedule), we remove support for Python 3.11. Many outdated patches/workarounds for these older (or even older) Python versions are removed, but I cannot guarantee that I've found all obsolete ones. Also CI tests for systems using Python 3.11 are removed. For next years cleaning job: - Change version in `pyproject.toml` and `build/pkgs/python3/spkg- configure.m4` - Search for `3.12`, `312`,`3,12`, `PY_VERSION`, `PY_MINOR_VERSION` and `sys.version_info` Similar PRs: - sagemath#39251 ### 📝 Checklist  - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies    - sagemath#39163 URL: sagemath#40936 Reported by: Tobias Diez Reviewer(s): Chenxin Zhong, Dima Pasechnik

tobiasdiez mentioned this pull request Oct 4, 2025

Build wheel, update CI and improve build system sagemath/cypari2#188

Merged

tobiasdiez mentioned this pull request Oct 30, 2025

bump cysignals to 1.12.6, cypari to 2.2.4 #41116

Merged

5 tasks

tobiasdiez marked this pull request as ready for review November 1, 2025 02:52

github-actions bot added the s: needs review label Nov 1, 2025

tobiasdiez requested review from cxzhong and dimpase November 1, 2025 02:55

cxzhong approved these changes Nov 1, 2025

View reviewed changes

Require Python 3.12 or newer; remove outdated workarounds

584ce1b

dimpase force-pushed the drop-311 branch from 6bb49a8 to 584ce1b Compare November 17, 2025 15:16

cxzhong suggested changes Nov 17, 2025

View reviewed changes

fixes for Python 3.14

a70ec5a

cxzhong approved these changes Nov 20, 2025

View reviewed changes

Remove Python 3.11 from CI configuration

4b71086

Removed configuration for Python 3.11 from CI workflow.

Merge pull request #20 from cxzhong/patch-7

d0e0d5c

Remove Python 3.11 from CI configuration

dimpase force-pushed the drop-311 branch from 84f27b8 to d0e0d5c Compare November 20, 2025 23:26

Fix documentation

6867d59

cxzhong added s: positive review and removed s: needs review labels Nov 21, 2025

dimpase approved these changes Nov 21, 2025

View reviewed changes

vbraun merged commit f78fe24 into sagemath:develop Dec 2, 2025
30 of 33 checks passed

github-actions bot removed the s: positive review label Dec 2, 2025

Uh oh!

Conversation

tobiasdiez commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📝 Checklist

⌛ Dependencies

Uh oh!

github-actions bot commented Sep 30, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tobiasdiez commented Nov 1, 2025

Uh oh!

cxzhong commented Nov 1, 2025

Uh oh!

tobiasdiez commented Nov 1, 2025

Uh oh!

cxzhong commented Nov 1, 2025

Uh oh!

cxzhong commented Nov 1, 2025

Uh oh!

dimpase commented Nov 4, 2025

Uh oh!

cxzhong commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dimpase commented Nov 4, 2025

Uh oh!

cxzhong commented Nov 4, 2025

Uh oh!

dimpase commented Nov 4, 2025

Uh oh!

dimpase commented Nov 4, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cxzhong commented Nov 4, 2025

Uh oh!

dimpase commented Nov 4, 2025

Uh oh!

cxzhong commented Nov 4, 2025

Uh oh!

dimpase commented Nov 4, 2025

Uh oh!

cxzhong commented Nov 14, 2025

Uh oh!

cxzhong Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

cxzhong Nov 17, 2025

Choose a reason for hiding this comment

Uh oh!

dimpase Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

dimpase Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

cxzhong Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

cxzhong Nov 18, 2025

Choose a reason for hiding this comment

Uh oh!

dimpase Nov 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cxzhong commented Nov 20, 2025

Uh oh!

cxzhong commented Nov 20, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cxzhong commented Nov 20, 2025

Uh oh!

cxzhong commented Nov 20, 2025

Uh oh!

dimpase commented Nov 20, 2025

Uh oh!

tobiasdiez commented Nov 21, 2025

Uh oh!

dimpase commented Nov 21, 2025

tobiasdiez commented Sep 30, 2025 •

edited

Loading

github-actions bot commented Sep 30, 2025 •

edited

Loading

cxzhong commented Nov 4, 2025 •

edited

Loading

dimpase commented Nov 4, 2025 •

edited

Loading

dimpase Nov 19, 2025 •

edited

Loading

cxzhong commented Nov 20, 2025 •

edited

Loading