Make computation of LU decomposition of matrix over GF(2^e) interruptible#40716
Merged
vbraun merged 3 commits intosagemath:developfrom Sep 21, 2025
Merged
Make computation of LU decomposition of matrix over GF(2^e) interruptible#40716vbraun merged 3 commits intosagemath:developfrom
vbraun merged 3 commits intosagemath:developfrom
Conversation
6b32468 to
d0350c7
Compare
|
Documentation preview for this PR (built with commit e7000e9; changes) is ready! 🎉 |
d0350c7 to
4022c3f
Compare
vneiger
reviewed
Sep 5, 2025
b7e5620 to
948a8a3
Compare
vneiger
approved these changes
Sep 7, 2025
Contributor
vneiger
left a comment
There was a problem hiding this comment.
Looks good to me. Thanks!
Member
|
I'm getting |
Contributor
Author
|
the reason is likely missing "must compile with C++" marker somewhere. That error is indicator of C++ requirement cython/cython#1910 . Still, I suspect the reason why this builds in test-long CI but fails in @vbraun 's build is #39030 (?) any idea why test-long CI doesn't fail? |
Closed
1 task
Contributor
Author
|
I fix the immediate issue, but not the full issue. See #40802 for more discussion. |
91ce4eb to
e7000e9
Compare
Contributor
Author
|
turns out the cause is just that it builds before the commit 3a956e4 , but not after it. Either way, should be fixed now. |
vneiger
approved these changes
Sep 11, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Sep 16, 2025
sagemathgh-40716: Make computation of LU decomposition of matrix over GF(2^e) interruptible As in the title. Before this change, the test fails. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40716 Reported by: user202729 Reviewer(s): user202729, Vincent Neiger
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in the title. Before this change, the test fails.
📝 Checklist
⌛ Dependencies