Skip to content

fixes in spkg-configure.m4's#40568

Merged
vbraun merged 3 commits intosagemath:developfrom
dimpase:m4fixes10.7
Sep 7, 2025
Merged

fixes in spkg-configure.m4's#40568
vbraun merged 3 commits intosagemath:developfrom
dimpase:m4fixes10.7

Conversation

@dimpase
Copy link
Member

@dimpase dimpase commented Aug 11, 2025

This allows external flint 3.3.*, and fixes errors in spkg-configure.4 of roman_numerals_py

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@dimpase dimpase requested a review from kiwifb August 11, 2025 05:21
@dimpase dimpase requested a review from vbraun August 11, 2025 05:21
@github-actions
Copy link

github-actions bot commented Aug 11, 2025 •
edited
Loading

Documentation preview for this PR (built with commit 2c45952; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@kiwifb
Copy link
Member

kiwifb commented Aug 11, 2025

Gosh, that was really me that made that "numerical" mistake. LGTM.

kiwifb
kiwifb approved these changes Aug 11, 2025
View reviewed changes
Copy link
Member

@kiwifb kiwifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dimpase dimpase mentioned this pull request Aug 11, 2025
Merged
5 tasks
@vbraun
Copy link
Member

vbraun commented Aug 12, 2025

doc-html fails

[sagemath_doc_html-none] [spkg-install] [valuation]       File "/home/release/Sage/local/var/lib/sage/venv-python3.12.5/lib/python3.12/site-packages/sphinx/registry.py", line 544, in load_extension      
[sagemath_doc_html-none] [spkg-install] [valuation]         raise ExtensionError(                                                                                                                          
[sagemath_doc_html-none] [spkg-install] [valuation]     sphinx.errors.ExtensionError: Could not import extension sphinx.builders.latex (exception: No module named 'roman_numerals')

@dimpase
Copy link
Member Author

dimpase commented Aug 12, 2025

@vbraun - can you provide top-level config.log for this run?

@dimpase
Copy link
Member Author

dimpase commented Aug 12, 2025

unless roman_numerals is misdetected as available, it must be something else

kiwifb
kiwifb reviewed Aug 19, 2025
View reviewed changes
@dimpase
Copy link
Member Author

dimpase commented Aug 21, 2025

@vbraun - fixed now

@dimpase
Copy link
Member Author

dimpase commented Aug 25, 2025

ping?

@dimpase dimpase requested a review from kiwifb August 25, 2025 15:51
@dimpase dimpase mentioned this pull request Aug 25, 2025
Merged
5 tasks
kiwifb
kiwifb approved these changes Aug 25, 2025
View reviewed changes
Copy link
Member

@kiwifb kiwifb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we all agree that it is now in shape.

@dimpase
Copy link
Member Author

dimpase commented Aug 29, 2025

trivial rebase, please merge this soon, in particular to allow usage of new system-wide Flint

@vbraun
Copy link
Member

vbraun commented Sep 1, 2025

Documentation build fails after 39030

@dimpase
Copy link
Member Author

dimpase commented Sep 1, 2025 •
edited
Loading

@vbraun - why do you mention #39030 here?
What does this PR have to do with it?

@dimpase
Copy link
Member Author

dimpase commented Sep 1, 2025 •
edited
Loading

@vbraun - building doc-html does work for me after merging this PR into #39030.
I'm pretty sure the problem you got is due to your workflow, which might have problem with a renamed standard package - and yes, this PR renames roman_numerals_py to roman_numerals.

@dimpase
Copy link
Member Author

dimpase commented Sep 4, 2025

@vbraun - have you figured this out?

@vbraun vbraun merged commit d0ec663 into sagemath:develop Sep 7, 2025
36 of 38 checks passed
vbraun pushed a commit to vbraun/sage that referenced this pull request Sep 11, 2025
248b65c 
sagemathgh-40555: Sirocco update to a pkg-config enabled version
    
~also fix a typo in `spkg-configure.m4` of `roman_numerals_py`, and fix
`spkg-configure.m4` of `flint` to allow versions 3.3.*~ (will be done
elsewhere - in sagemath#40568)

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. -->

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - sagemath#12345: short description why this is a dependency -->
<!-- - sagemath#34567: ... -->
    
URL: sagemath#40555
Reported by: Dima Pasechnik
Reviewer(s): Dima Pasechnik, Tobias Diez
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vbraun vbraun Awaiting requested review from vbraun

1 more reviewer

@kiwifb kiwifb kiwifb approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dimpase @kiwifb @vbraun