Constructor for the Carlitz module#40433
Merged
vbraun merged 23 commits intosagemath:developfrom Aug 27, 2025
Merged
Conversation
kryzar
reviewed
Jul 18, 2025
src/sage/rings/function_field/drinfeld_modules/carlitz_module.py
Outdated
Show resolved
Hide resolved
|
Documentation preview for this PR (built with commit b201d77; changes) is ready! 🎉 |
kryzar
approved these changes
Aug 11, 2025
Contributor
kryzar
left a comment
kryzar
left a comment
There was a problem hiding this comment.
Lovely.
(Failing tests (stuff in src/sage/interfaces/gap.py or internal cuisine) are unrelated to the PR.)
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 12, 2025
sagemathgh-40433: Constructor for the Carlitz module We add a constructor for instantiating easily the Carlitz module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40433 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
kryzar
approved these changes
Aug 13, 2025
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 13, 2025
sagemathgh-40433: Constructor for the Carlitz module We add a constructor for instantiating easily the Carlitz module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40433 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
github-actions
bot
added
s: needs review
and removed
s: positive review
s: needs work
labels
5 tasks
Contributor
Author
|
Don't understand where the error on |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Aug 21, 2025
sagemathgh-40433: Constructor for the Carlitz module We add a constructor for instantiating easily the Carlitz module. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies sagemath#40430, sagemath#40436 URL: sagemath#40433 Reported by: Xavier Caruso Reviewer(s): Antoine Leudière, Xavier Caruso
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We add a constructor for instantiating easily the Carlitz module.
📝 Checklist
⌛ Dependencies
#40430, #40436