Use python3 -m sage.doctest in doctest results report if not using sage-runtests#40332
Use python3 -m sage.doctest in doctest results report if not using sage-runtests#40332vbraun merged 5 commits intosagemath:developfrom
python3 -m sage.doctest in doctest results report if not using sage-runtests#40332Conversation
|
Documentation preview for this PR (built with commit 7ff88f2; changes) is ready! 🎉 |
| ... --long .../sage/doctest/reporting.py # Failed by self-sabotage | ||
| """ | ||
| cmd = "sage -t" | ||
| cmd = "sage-runtests" if "sage-runtests" in argv[0] else "python3 -m sage.doctest" |
There was a problem hiding this comment.
Why change it from sage -t to sage-runtests?
There was a problem hiding this comment.
Just to minimize the wrapping layers - I didn't make it python3 -m sage.doctest unconditionally because sage may not be installed in the system python namespace
|
CI is failing now, seems like a typo in the merge resolution. |
Thanks, fixed. |
|
Follow-up at #40704 |
|
The test failures are now reported as which isn't a command that I can easily run from the repo root. IMHO thats a definite regression, it is much clearer to output a command that you can just run to re-run the test |
That's easy to change, but note that, depending on your PATH, |
|
a full path would be ok with me, I don't understand why we need a different command though (but then thats arguably less important) |
|
What about the relative path from the root? So src/bin/sage-runtests ? I think it's most common to execute stuff from the root, at least CI is doing this. |
sagemathgh-40704: Fix one more optional test Fallout from sagemath#40332, wasn't detected there because it depends on meataxe URL: sagemath#40704 Reported by: Antonio Rojas Reviewer(s):
3 participants
Instead of
sage -t, which no longer works with meson