update planaritry to 4.0.0.0#40153
Merged
vbraun merged 3 commits intosagemath:developfrom Jun 14, 2025
Merged
Conversation
2 tasks
Contributor
|
It works in Fedora 42, and the gnu17 option is no more needed now. |
Contributor
|
You'll also need the Gentoo patch for dev-gap/digraphs |
Contributor
|
And this fedora patch for semigroups would help for gap_packages. |
Contributor
|
works on Arch, thanks! |
gmou3
approved these changes
May 24, 2025
Contributor
|
The |
Member
Author
|
@antonio-rojas this should fix the regression you pointed out. Hopefully upstream has settled on the header naming scheme. |
Member
Author
I gather it's https://gitweb.gentoo.org/repo/gentoo.git/tree/dev-gap/digraphs/files/digraphs-planarity-4.x.patch |
Member
Author
|
@antonio-rojas - could you review it? |
Contributor
|
Builds on Arch and uses system planarity |
long overdue - also, supports gcc-15 out of the box
removed compile checks, as they were testing for a very old planarity version, and keeping it needs figuring out the header version to use.
|
Documentation preview for this PR (built with commit 9c31736; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 4, 2025
sagemathgh-40153: update planaritry to 4.0.0.0 long overdue - also, supports gcc-15 out of the box ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40153 Reported by: Dima Pasechnik Reviewer(s): gmou3
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 6, 2025
sagemathgh-40153: update planaritry to 4.0.0.0 long overdue - also, supports gcc-15 out of the box ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40153 Reported by: Dima Pasechnik Reviewer(s): gmou3
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 8, 2025
sagemathgh-40153: update planaritry to 4.0.0.0 long overdue - also, supports gcc-15 out of the box ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40153 Reported by: Dima Pasechnik Reviewer(s): gmou3
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40153: update planaritry to 4.0.0.0 long overdue - also, supports gcc-15 out of the box ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40153 Reported by: Dima Pasechnik Reviewer(s): gmou3
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40153: update planaritry to 4.0.0.0 long overdue - also, supports gcc-15 out of the box ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40153 Reported by: Dima Pasechnik Reviewer(s): gmou3
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 9, 2025
sagemathgh-40153: update planaritry to 4.0.0.0 long overdue - also, supports gcc-15 out of the box ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#40153 Reported by: Dima Pasechnik Reviewer(s): gmou3
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 21, 2025
sagemathgh-40204: Remove pkgconf spkg `pkgconf`, a.k.a. `pkg-config`, is available on all systems we support - even on the "naked" (no homebrew/macports) macOS one can install a formally certified/notarised package https://github.com/donmccaughey/pkg-config_pkg - so there is no reason to keep it in the tree. There are big advantages to have pkg-config available at configure time, as recognition of several crucial external spkgs, such as (open)blas, zlib, etc. hinges upon pkg-config. With this PR in, we proceed to remove them. Last but not the least, it simplifies the Makefile by getting rid of `base` target, which becomes empty ## 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#40011 - remove bzip2 spkg. - sagemath#40153 - planarity spkg fix (can't build otherwise) URL: sagemath#40204 Reported by: Dima Pasechnik Reviewer(s): Dima Pasechnik, Tobias Diez
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 25, 2025
sagemathgh-40204: Remove pkgconf spkg `pkgconf`, a.k.a. `pkg-config`, is available on all systems we support - even on the "naked" (no homebrew/macports) macOS one can install a formally certified/notarised package https://github.com/donmccaughey/pkg-config_pkg - so there is no reason to keep it in the tree. There are big advantages to have pkg-config available at configure time, as recognition of several crucial external spkgs, such as (open)blas, zlib, etc. hinges upon pkg-config. With this PR in, we proceed to remove them. Last but not the least, it simplifies the Makefile by getting rid of `base` target, which becomes empty ## 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - sagemath#40011 - remove bzip2 spkg. - sagemath#40153 - planarity spkg fix (can't build otherwise) URL: sagemath#40204 Reported by: Dima Pasechnik Reviewer(s): Dima Pasechnik, Tobias Diez
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
long overdue - also, supports gcc-15 out of the box
📝 Checklist
⌛ Dependencies