Skip to content

correct the index type in Boost interface#39850

Closed
dimpase wants to merge 1 commit intosagemath:developfrom
dimpase:cast_boost
Closed

correct the index type in Boost interface#39850
dimpase wants to merge 1 commit intosagemath:developfrom
dimpase:cast_boost

Conversation

@dimpase
Copy link
Copy Markdown
Member

@dimpase dimpase commented Apr 2, 2025

without this fix, conda build of Sage 10.6 is failing;
this is with clang 18.1.8

This was reported on https://groups.google.com/g/sage-devel/c/YSiaVdsLKQg/m/13mZHNErCAAJ,
but the cause wasn't identified correctly.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

without this fix, conda build is failing; this is clang 18.1.8
@dimpase
Copy link
Copy Markdown
Member Author

dimpase commented Apr 2, 2025

@saraedum @tobiasdiez

@github-actions
Copy link
Copy Markdown

github-actions bot commented Apr 2, 2025

Documentation preview for this PR (built with commit bfc87ec; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@dimpase dimpase changed the title correct the index typo in Boost interface correct the index type in Boost interface Apr 2, 2025
@dimpase
Copy link
Copy Markdown
Member Author

dimpase commented Apr 2, 2025

@dcoudert - perhaps a better fix here would be to change the type on the cython side, not on the C++ side?

@tobiasdiez
Copy link
Copy Markdown
Contributor

Is this the same problem that #39526 fixes?

@dimpase
Copy link
Copy Markdown
Member Author

dimpase commented Apr 3, 2025

closing in favour of a better solution on #39526

@dimpase dimpase closed this Apr 3, 2025
@dimpase dimpase deleted the cast_boost branch April 3, 2025 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants