Fix typo in SAGE_PARI_MINVER#39700
Merged
vbraun merged 1 commit intosagemath:developfrom Mar 22, 2025
Merged
Conversation
2.17.0 is broken and shouldn't be accepted
|
Documentation preview for this PR (built with commit e5657ec; changes) is ready! 🎉 |
dimpase
approved these changes
Mar 14, 2025
Member
dimpase
left a comment
dimpase
left a comment
There was a problem hiding this comment.
LGTM. Please flip the labels to positive review.
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Mar 19, 2025
sagemathgh-39700: Fix typo in SAGE_PARI_MINVER 2.17.0 is broken and shouldn't be accepted Amends sagemath#38749 URL: sagemath#39700 Reported by: Antonio Rojas Reviewer(s): Dima Pasechnik
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2.17.0 is broken and shouldn't be accepted
Amends #38749