Add some 'not tested' marks to avoid CI failure#39664
Add some 'not tested' marks to avoid CI failure#39664vbraun merged 1 commit intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit 69331d9; changes) is ready! 🎉 |
|
I'm unsure if "not tested" or "known bug" is more appropriate. The former seems to be used more often when the tests have some side effects (eg a window opens) and thus you normally don't want to run the tests. Otherwise looks good to me. |
-- #39470 (comment) ? there's always an option of adding a "known occasional bug" tag or something. |
|
Suppose you have a But anyway, let's not get super focused on the terminology. The important thing is that these bugs are documented for users, and this is also achieved by using |
sagemathgh-39664: Add some 'not tested' marks to avoid CI failure As in the title. I don't think there's any advantage in running the test again. There's only a very small risk of the fixer forget to delete the marker, but it seems like a nonexistent issue (whichever pull request that fix it should also remove the `# not tested`) At least for those that doesn't segmentation fault or hang. (For those who do the only solution I can think of is sagemath#39539 ) Side note: not sure what's a good solution to this. Maybe we can do sagemath#39470 instead? (but then it doesn't apply to meson…) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39664 Reported by: user202729 Reviewer(s):
As in the title. I don't think there's any advantage in running the test again.
There's only a very small risk of the fixer forget to delete the marker, but it seems like a nonexistent issue (whichever pull request that fix it should also remove the
# not tested)At least for those that doesn't segmentation fault or hang.
Side note: not sure what's a good solution to this. Maybe we can do #39470 instead? (but then it doesn't apply to meson…)
📝 Checklist
⌛ Dependencies