Refactor %%cython to use IPython magic_arguments module#39434
Closed
user202729 wants to merge 5 commits intosagemath:developfrom
Closed
Refactor %%cython to use IPython magic_arguments module#39434user202729 wants to merge 5 commits intosagemath:developfrom
user202729 wants to merge 5 commits intosagemath:developfrom
Conversation
5 tasks
|
Documentation preview for this PR (built with commit 6eb035f; changes) is ready! 🎉 |
Contributor
Author
|
The documentation rendering doesn't seem to work too well? Obviously because of the added text in the docstring by the decorators. Besides, why is the initial line |
Collaborator
|
Then I see no real benefit of using the IPython helper module for sage users... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Refactor to use https://ipython.readthedocs.io/en/stable/api/generated/IPython.core.magic_arguments.html
Feature was originally added in #38945 before I realize the IPython helper module exists.
There's slight change in error message for unbalanced quotes, but I think it doesn't matter. (Edit: for simple cases it doesn't matter. See discussion in ipython/ipython#2001 )
📝 Checklist
⌛ Dependencies