Mark test as random to avoid failure#39377
Conversation
|
Documentation preview for this PR (built with commit e75bf95; changes) is ready! 🎉 |
|
I think the point of the test (going back to #252) is that the number field is created successfully, so why not... sage: K
Number Field in a with defining polynomial 2*x^4 + 6*x^2 + 1/2Otherwise we are only wasting a few milliseconds generating output that isn't checked and isn't very instructive. |
|
@orlitzky actually the following line is checked it checks the sorted numerical values of the discriminants (if you want to be extra careful we can also check the degree, but I think this is enough) |
That part is fine. It's, that I think is taking up a lot of space for no benefit. Sometimes you have to print a random number to show how a method works, but here, displaying a bunch of semi-random output isn't really helping to explain (or test) anything. |
|
(Instead of printing the subfields, I was suggesting printing |
|
And actually, this is a |
|
Cool, thanks. I have faith that CI will pass. |
Fix issue pointed out in #39153 (comment)
📝 Checklist
⌛ Dependencies