Closed
Conversation
as autoconf's generated configure clobbers conftest*, we are saving conftest.py from it by making a backup copy and then restoring it after the real configure was run.
1 task
|
Documentation preview for this PR (built with commit 62c1b97; changes) is ready! 🎉 |
Member
|
Oh, I see! I overlooked that, rather weird to me, thing. I thought all such setup is done by git and git-related code. |
Contributor
Author
|
You can cherry-pick the commits on your pull request (or just make the change yourself), I suppose. Maybe add this (or appropriate wording) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index bbecdf4..408b6c8 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -308,6 +308,8 @@ jobs:
- name: Generate Dockerfile
# From docker.yml
+ # The `tox -e <environment name>` command runs a few commands in `tox.ini`,
+ # which includes `.ci/write-dockerfile.sh` to generate `Dockerfile`.
run: |
tox -e ${{ env.TOX_ENV }}
cp .tox/${{ env.TOX_ENV }}/Dockerfile .(thanks 😁 that probably took me an hour or two to find) |
Member
|
thanks, I cherry picked. A more githubby way would have been for you to open a PR to the branch of the patent PR in my fork. Then I could have just merged the branch here into my fork. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Checklist
⌛ Dependencies