Some improvements to findstat._submit#39193
Conversation
|
Documentation preview for this PR (built with commit 4a82a39; changes) is ready! 🎉 |
|
I actually didn't realise that it was broken - I use it regularly. The main nuisance is that firefox doesn't access |
|
webbrowser.open(file path) is platform dependent, https://docs.python.org/3/library/webbrowser.html#webbrowser.open . The issue with Another approach might be to use data:html URL, but it isn't very clear that would be more platform independent than the current one. [edit: I just tried, |
mantepse
left a comment
There was a problem hiding this comment.
Looks OK - I cannot say much about it, though. There is no change visible to me on my system (Ubuntu 24.04).
sagemathgh-39193: Some improvements to findstat._submit * for some reason the proper header is needed to open the HTML file on my machine. * It's reported that `webbrowser.open()` doesn't work when called on a file path, rather an URI is needed (sagemath#38946) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation and checked the documentation preview. (not needed) ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39193 Reported by: user202729 Reviewer(s): Martin Rubey
webbrowser.open()doesn't work when called on a file path, rather an URI is needed (Allow Cython compilation to open a web browser containing the annotated HTML file #38946)📝 Checklist
⌛ Dependencies