Skip to content

Fix find_replacements with Python 3.13 #39185

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vbraun merged 3 commits into from
Jan 18, 2025
Merged

Fix find_replacements with Python 3.13 #39185

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
481db2a
Fix find_replacements with Python 3.13
antonio-rojas Dec 22, 2024
b8cd5a6
Simplify
antonio-rojas Dec 22, 2024
cee808a
Use temporary dict as globals
antonio-rojas Dec 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions src/sage/misc/replace_dot_all.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,14 +194,15 @@ def find_replacements(location, package_regex=None, verbose=False):
to_exec = to_exec.replace("'", '').replace('"', '')
if (to_exec[-1] == ','):
to_exec = to_exec[:-1]
exec(to_exec)
glob = dict()
exec(to_exec, glob)
except ModuleNotFoundError as err:
print(f'ModuleNotFoundError: {err} found when trying to execute {to_exec}')
except ImportError as err:
print(f'ImportError: {err} found when trying to execute {to_exec}')

try: # try to evaluate the list of module names to get a list of the modules themselves which we can call import_statements on
modules = eval(to_eval)
modules = eval(to_eval, glob)
except NameError as err:
print(f'NameError: {err} found when trying to evaluate {to_eval} at {location}:{row_index + 1}')
except SyntaxError as err:
Expand Down