Remove executable flags from many Python files#39149
Merged
vbraun merged 1 commit intosagemath:developfrom Dec 22, 2024
Merged
Conversation
|
Documentation preview for this PR (built with commit f397173; changes) is ready! 🎉 |
yyyyx4
added
s: positive review
p: trivial / 5
t: refactoring
and removed
s: needs review
labels
Member
|
Thanks! Looks good to me. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Dec 19, 2024
sagemathgh-39149: Remove executable flags from many Python files For some reason many files are set to be executable. (Presumably some developer `git clone` sage on some NTFS-based file system or otherwise don't have proper permissions) Some of the changes was previously seen in sagemath#38155 or https://github.com/sagema th/sage/commit/c24e07df70ad46cae0f6a2f58778a90dbb843e05, which has nothing to do with executable. On the other hand some files looks like they can rightfully be executable (because they have the `#!`): ext_data/pari/dokchitser/testall and ext_data/nbconvert/postprocess.py . These files are kept as is. Moving forward… it might be good idea to have something run on the CI to check only files with `#!` or PE executable have executable flag. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#39149 Reported by: user202729 Reviewer(s):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For some reason many files are set to be executable. (Presumably some developer
git clonesage on some NTFS-based file system or otherwise don't have proper permissions)Some of the changes was previously seen in #38155 or c24e07d, which has nothing to do with executable.
On the other hand some files looks like they can rightfully be executable (because they have the
#!): ext_data/pari/dokchitser/testall and ext_data/nbconvert/postprocess.py . These files are kept as is.Moving forward… it might be good idea to have something run on the CI to check only files with
#!or PE executable have executable flag.📝 Checklist
⌛ Dependencies