simplify some call of isinstance in pyx files#39146
Merged
vbraun merged 4 commits intosagemath:developfrom Jan 4, 2025
Merged
Conversation
|
Documentation preview for this PR (built with commit fd987c2; changes) is ready! 🎉 |
mantepse
changed the title
Contributor
|
There might be a trivial merge conflict with #38207, I should check. |
Contributor
Author
|
I do not think we have to care in advance for merge conflicts. Rather we should handle them when and if they appear. |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jan 1, 2025
sagemathgh-39146: simplify some call of isinstance in pyx files by gathering the possible types ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#39146 Reported by: Frédéric Chapoton Reviewer(s): Martin Rubey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
by gathering the possible types
📝 Checklist