Skip to content

CI: Create doc directory regardless of develop or PR#38378

Merged
vbraun merged 1 commit intosagemath:developfrom
kwankyu:p/fix-doc-develop
Jul 19, 2024
Merged

CI: Create doc directory regardless of develop or PR#38378
vbraun merged 1 commit intosagemath:developfrom
kwankyu:p/fix-doc-develop

Conversation

@kwankyu
Copy link
Collaborator

@kwankyu kwankyu commented Jul 17, 2024

Fix a problem seen in: https://doc-develop--sagemath.netlify.app/html/en/index.html

Tested in https://github.com/kwankyu/sage/actions/runs/9966461690.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@kwankyu kwankyu changed the title Create doc directory regardless of develop or PR CI: Create doc directory regardless of develop or PR Jul 17, 2024
@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 17, 2024

This should have been in the blocker PR #38353. At the time, I noticed the problem but didn't scrutinize the root cause, expecting things to be sorted out in the next release. But it did not. Sigh...

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 17, 2024

@vbraun I didn't set this PR as a blocker, wishing not to delay the release of 10.4. But it would be nice to include this PR with the release or with the first beta.

@github-actions
Copy link

Documentation preview for this PR (built with commit 40603ea; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 17, 2024

Let's please merge it in 10.4. This is a "CI Manager" type fix and does not need another rc.

1 similar comment
@mkoeppe
Copy link
Contributor

mkoeppe commented Jul 17, 2024

Let's please merge it in 10.4. This is a "CI Manager" type fix and does not need another rc.

@kwankyu
Copy link
Collaborator Author

kwankyu commented Jul 17, 2024

Thanks!

@vbraun vbraun merged commit 3c279ec into sagemath:develop Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants