Conversation
|
Documentation preview for this PR (built with commit 2faf15f; changes) is ready! 🎉 |
|
Thanks, Volker. |
sagemathgh-37998: Update conda-lock files, rename macOS conda-lock files to match CI Conda, remove unexplained duplicate lock files <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The renaming is done so that the fix here can take effect on PR runs via the "CI Fix" mechanism (as changes to the workflow files themselves cannot take effect). - Moreover, making arm64 the default platform for macOS makes sense because all new macOS machines use this platform. And update by running `.github/workflows/conda-lock-update.py` for all architectures. - Workflow matrix variables now contain `-latest`, to add tests for the macOS x86_64 platform (runner name: `macos-13`) - Removes some unexplained duplications (both `arm` and `arm64` files for macOS, both `aarch` and `aarch64` for Linux) - Fixes sagemath#37997 Author: @mkoeppe, @gmou3 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#38033 (split out from here) - Depends on sagemath#38034 (split out from here) - Depends on sagemath#38222 URL: sagemath#37998 Reported by: Matthias Köppe Reviewer(s):
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> URL: sagemath#38222 Reported by: Matthias Köppe Reviewer(s):
|
-1 Nothing here explains why this should be a blocker, not even why this should happen at all. |
|
#37884 (comment) shows that whatever issue you have is not about gap 4.13 but about a particular (broken?) install of gap. |
Because we're trying to make a release, and your PR #37884 is not ready. |
sagemathgh-37998: Update conda-lock files, rename macOS conda-lock files to match CI Conda, remove unexplained duplicate lock files <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes sagemath#12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes sagemath#12345". --> The renaming is done so that the fix here can take effect on PR runs via the "CI Fix" mechanism (as changes to the workflow files themselves cannot take effect). - Moreover, making arm64 the default platform for macOS makes sense because all new macOS machines use this platform. And update by running `.github/workflows/conda-lock-update.py` for all architectures. - Workflow matrix variables now contain `-latest`, to add tests for the macOS x86_64 platform (runner name: `macos-13`) - Removes some unexplained duplications (both `arm` and `arm64` files for macOS, both `aarch` and `aarch64` for Linux) - Fixes sagemath#37997 Author: @mkoeppe, @gmou3 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - sagemath#12345: short description why this is a dependency --> <!-- - sagemath#34567: ... --> - Depends on sagemath#38033 (split out from here) - Depends on sagemath#38034 (split out from here) - Depends on sagemath#38222 (merged here) URL: sagemath#37998 Reported by: Matthias Köppe Reviewer(s): Kwankyu Lee
Come on, #37884 is 100% ready, blame your #38169. But note that updating 4.12.2 to 4.13.1 doesn't need anything special for us (https://github.com/void-linux/void-packages/pull/49571/files#diff-d5e8ac4c14235608656fe702205ba0e985de306ecc14756391643152370bfbd3). |
|
Please @tornaria. As you know, #37884 is not in a shape to be merged because nobody implemented the proposed solutions to support both the old and the new version (see #37884 (comment)). |
Please @mkoeppe. As you know, #37884 is 100% ready to run sagemath with gap 4.13.0 or 4.13.1. The reason forhy #38169 is not ready escapes me. |
|
... and there is nothing here that explains the reason to reject system gap 4.13. |
|
@tornaria The Release Manager will simply not merge a PR such as #37884 that requires a newer version of a library than what is provided by the Sage distribution -- because he tests with the Sage distribution, the tests will fail, and he'll set it back to "needs work". So whenever you want to prepare a PR that adds support for a newer version of a library,
But I'm pretty sure that you know all that. So what's with the "Come on" and "Please"? |
4 participants
📝 Checklist
⌛ Dependencies