Fix test failure on 32-bit where a different element is picked#38148
Merged
vbraun merged 1 commit intosagemath:developfrom Jun 9, 2024
Merged
Fix test failure on 32-bit where a different element is picked#38148vbraun merged 1 commit intosagemath:developfrom
vbraun merged 1 commit intosagemath:developfrom
Conversation
|
Documentation preview for this PR (built with commit 6951817; changes) is ready! 🎉 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Jun 5, 2024
sagemathgh-38148: Fix test failure on 32-bit where a different element is picked On Debian 12 32-bit I get: ``` ********************************************************************** File "src/sage/geometry/polyhedral_complex.py", line 935, in sage.geometry.polyhedral_complex.PolyhedralComplex._an_element_ Failed example: pc._an_element_().vertices_list() Expected: [[0, 0], [0, 1/2], [1, 2]] Got: [[0, 0], [1/3, 1/3], [1, 2]] ********************************************************************** 1 item had failures: 1 of 4 in sage.geometry.polyhedral_complex.PolyhedralComplex._an_element_ [469 tests, 1 failure, 17.41 s] ---------------------------------------------------------------------- sage -t --long --random-seed=0 src/sage/geometry/polyhedral_complex.py # 1 doctest failed ---------------------------------------------------------------------- ``` Just accept either of the two maximal cells URL: sagemath#38148 Reported by: Volker Braun Reviewer(s): Matthias Köppe
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Debian 12 32-bit I get:
Just accept either of the two maximal cells