Skip to content

code polishing using list comprehension#38131

Merged
vbraun merged 3 commits intosagemath:developfrom
fchapoton:more_list_comprehensions
Jun 9, 2024
Merged

code polishing using list comprehension#38131
vbraun merged 3 commits intosagemath:developfrom
fchapoton:more_list_comprehensions

Conversation

@fchapoton
Copy link
Contributor

simplify code in various places by using more list comprehension, as suggested by ruff --select=PERF4

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.

@github-actions
Copy link

github-actions bot commented Jun 2, 2024

Documentation preview for this PR (built with commit 9da8cb2; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

Copy link
Contributor

@mkoeppe mkoeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

Co-authored-by: Matthias Köppe <mkoeppe@math.ucdavis.edu>
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 3, 2024
sagemathgh-38131: code polishing using list comprehension
    
simplify code in various places by using more list comprehension, as
suggested by `ruff --select=PERF4`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38131
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 4, 2024
sagemathgh-38131: code polishing using list comprehension
    
simplify code in various places by using more list comprehension, as
suggested by `ruff --select=PERF4`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38131
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
vbraun pushed a commit to vbraun/sage that referenced this pull request Jun 5, 2024
sagemathgh-38131: code polishing using list comprehension
    
simplify code in various places by using more list comprehension, as
suggested by `ruff --select=PERF4`

### 📝 Checklist

- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
    
URL: sagemath#38131
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe
@vbraun vbraun merged commit 5af73d3 into sagemath:develop Jun 9, 2024
@fchapoton fchapoton deleted the more_list_comprehensions branch June 9, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants