Skip to content

Conversation

@mkoeppe
Copy link
Contributor

@mkoeppe mkoeppe commented May 1, 2024

Fixes #7991.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@github-actions
Copy link

github-actions bot commented May 1, 2024

Documentation preview for this PR (built with commit a846ef0; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@orlitzky
Copy link
Contributor

This predates our random methods actually being random. I think it would be more transparent/direct to add TESTS: to each of the kernel methods that constructs a random matrix (random size, random base ring, random entries) and then checks these properties.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Generic matrix testing -- left and right kernel

3 participants