gap: don't use deprecated LaTeX() and LaTeXObj()#37883
Merged
vbraun merged 1 commit intosagemath:developfrom May 2, 2024
Merged
gap: don't use deprecated LaTeX() and LaTeXObj()#37883vbraun merged 1 commit intosagemath:developfrom
vbraun merged 1 commit intosagemath:developfrom
Conversation
These functions were removed in 4.13.
2 tasks
|
Documentation preview for this PR (built with commit da9305a; changes) is ready! 🎉 |
tscrim
added
s: positive review
c: packages: standard
and removed
s: needs review
labels
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 28, 2024
These functions were removed in 4.13, but they weren't very good anyway. This PR replaces its usage. It should work fine on old gap so this can be merged just fine. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: sagemath#37883 Reported by: Gonzalo Tornaría Reviewer(s): Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These functions were removed in 4.13, but they weren't very good anyway.
This PR replaces its usage. It should work fine on old gap so this can be merged just fine.
📝 Checklist