make map_coefficients more general#37271
Closed
mantepse wants to merge 11 commits intosagemath:developfrom
Closed
Conversation
…rent base rings work now
|
Documentation preview for this PR (built with commit 28a8d17; changes) is ready! 🎉 |
Contributor
Author
|
Superseded by #37766 |
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 20, 2024
sagemathgh-37766: modules with basis/map coefficients This is a replacement for sagemath#37271, without dependency on the construction functor for symmetric functions. Fixes sagemath#18264 URL: sagemath#37766 Reported by: Martin Rubey Reviewer(s): Martin Rubey, Matthias Köppe, Travis Scrimshaw
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Apr 25, 2024
sagemathgh-37766: modules with basis/map coefficients This is a replacement for sagemath#37271, without dependency on the construction functor for symmetric functions. Fixes sagemath#18264 URL: sagemath#37766 Reported by: Martin Rubey Reviewer(s): Martin Rubey, Matthias Köppe, Travis Scrimshaw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The internal documentation of
categories/modules_with_basis.pymentionsIn line with this, we allow a new keyword
new_base_ringargument formap_coefficients, and allow maps that are not necessarily endofunctions.In particular, this fixes #18264. In the end, this is needed for #37033, where we need a generic way to retract a module element to a smaller coefficient ring, if possible.
Unfortunately, I am unable to find the discussion on sage-devel anymore. The current PR is certainly not optimal.
Dependencies: #37220