a few details in combinat folder #37245
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Documentation preview for this PR (built with commit 0a56fbf; changes) is ready! 🎉 |
dcoudert
reviewed
Feb 7, 2024
dcoudert
approved these changes
Feb 7, 2024
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 7, 2024
namely
- use ruff to fix some containement tests
- add links to some error codes in the doc
### 📝 Checklist
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
URL: sagemath#37245
Reported by: Frédéric Chapoton
Reviewer(s): David Coudert, Frédéric Chapoton
grhkm21
reviewed
Feb 12, 2024
| @@ -709,7 +709,7 @@ def steiner_quadruple_system(n, check=False): | |||
| ....: sqs = designs.steiner_quadruple_system(n, check=True) | |||
| """ | |||
| n = int(n) | |||
| if not ((n % 6) in [2, 4]): | |||
| if (n % 6) not in [2, 4]: | |||
There was a problem hiding this comment.
(Not mandatory but) should this check be moved to the bottom of the if-else chain? Especially since there is an error at the end that says "this should never happen".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
namely
use ruff to fix some containement tests
add links to some error codes in the doc
📝 Checklist