-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
a few details in combinat folder #37245
Conversation
Documentation preview for this PR (built with commit 0a56fbf; changes) is ready! 🎉 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the explanation.
LGTM.
namely - use ruff to fix some containement tests - add links to some error codes in the doc ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: sagemath#37245 Reported by: Frédéric Chapoton Reviewer(s): David Coudert, Frédéric Chapoton
@@ -709,7 +709,7 @@ def steiner_quadruple_system(n, check=False): | |||
....: sqs = designs.steiner_quadruple_system(n, check=True) | |||
""" | |||
n = int(n) | |||
if not ((n % 6) in [2, 4]): | |||
if (n % 6) not in [2, 4]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Not mandatory but) should this check be moved to the bottom of the if
-else
chain? Especially since there is an error at the end that says "this should never happen".
namely
use ruff to fix some containement tests
add links to some error codes in the doc
📝 Checklist