Move some code from Brandt modules to quaternion algebras#37090
Merged
vbraun merged 5 commits intosagemath:developfrom Mar 31, 2024
Merged
Move some code from Brandt modules to quaternion algebras#37090vbraun merged 5 commits intosagemath:developfrom
vbraun merged 5 commits intosagemath:developfrom
Conversation
Contributor
Author
|
#sd123 |
Member
|
merge conflict |
Member
|
I'm getting lots of errors after merging this, please try it on the newest develop branch |
|
Documentation preview for this PR (built with commit 78a3090; changes) is ready! 🎉 |
3 tasks
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 5, 2026
sagemathgh-41578: remove all deprecated stuff in modular again after sagemath#38184 ; Closed Date: 2024-06-22 sagemath#37090 ; Closed Date: 2024-03-31 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41578 Reported by: Frédéric Chapoton Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 7, 2026
sagemathgh-41578: remove all deprecated stuff in modular again after sagemath#38184 ; Closed Date: 2024-06-22 sagemath#37090 ; Closed Date: 2024-03-31 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41578 Reported by: Frédéric Chapoton Reviewer(s):
vbraun
pushed a commit
to vbraun/sage
that referenced
this pull request
Feb 10, 2026
sagemathgh-41578: remove all deprecated stuff in modular again after sagemath#38184 ; Closed Date: 2024-06-22 sagemath#37090 ; Closed Date: 2024-03-31 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: sagemath#41578 Reported by: Frédéric Chapoton Reviewer(s):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This moves the following helper functions from Brandt modules to (public or private) methods of quaternion algebras, where they should be easier to access:
basis_for_left_ideal()function: moved to_left_ideal_basis()methodright_order()function: moved to_right_order_from_ideal_basis()methodquaternion_order_with_given_level()function: moved toorder_with_level()methodWe add deprecations for these functions and also deprecate the function
maximal_order()in favour of the existingmaximal_order()method of quaternion algebras.