-
-
Notifications
You must be signed in to change notification settings - Fork 438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use Parent in Monsky-Washnitzer #37079
Conversation
The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition to the comments below, can you explain a bit about why you removed the __neg__
? The generic implementation seems like it would be slower (I don't know how much that would matter though).
Should we also try and fix the pickling issue to? Could you say at least a bit more about the failure? In particular, on which class(es)?
TestSuite in fact seem to be all ok. I added one missing and it works. About I have removed the comments and added one |
Was it failing before the
This is very strange to me. It very clearly should work. I am worried it is hiding a bug. Can you say a bit more about the failures?
Thank you. PS - Did you also get my email about March? |
ok, so I have added back Sorry for the unanswered mail. I will do that now. |
Documentation preview for this PR (built with commit 1c4c375; changes) is ready! 🎉 |
That is just as strange. Well, I am happy that it is working as I would have expected it to. Thank you. This is now a positive review.
No problem. Thank you. I wasn't sure if it ended up in a spam folder or was some outdated email (Japanese universities seem to enjoy changing email addresses every few years in some cases...). |
use
Parent
in the modified filealso removing
__neg__
methodand some other details
📝 Checklist